Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] update to latest action using node20 instead of deprecated node16 #371

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

maurerle
Copy link
Collaborator

Currently each pipeline has warnings to it regarding the deprecation of node.js 16 actions like:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This PR updates the versions of the pipeline accordingly.
See also:

https://github.com/actions/checkout/releases
https://github.com/korthout/backport-action/releases
https://github.com/softprops/action-gh-release/releases

@maurerle maurerle requested review from goligo and grische March 10, 2024 21:34
@maurerle maurerle requested a review from a team as a code owner March 10, 2024 21:34
@T0biii
Copy link
Member

T0biii commented Mar 11, 2024

for upload-artifacts@v4 see:
b25ce0a
Currently, the download-artifact@v3 does not find any artifacts anymore since the bump of upload-artifact to v4.

@GoliathLabs
Copy link
Member

for upload-artifacts@v4 see: b25ce0a Currently, the download-artifact@v3 does not find any artifacts anymore since the bump of upload-artifact to v4.

should we even upgrade then?

@GoliathLabs
Copy link
Member

for upload-artifacts@v4 see: b25ce0a Currently, the download-artifact@v3 does not find any artifacts anymore since the bump of upload-artifact to v4.

should we even upgrade then?

Nvm. It was already broken

@GoliathLabs GoliathLabs merged commit b7c99f1 into stable Mar 11, 2024
28 checks passed
@GoliathLabs GoliathLabs deleted the actions-update-nodejs branch March 11, 2024 11:19
@grische
Copy link
Contributor

grische commented Mar 11, 2024

No, please don't upgrade those. This will break release creation.

@grische grische added the backport next Backport to Next Branch label Mar 27, 2024
Copy link
Contributor

Backport failed for next, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin next
git worktree add -d .worktree/backport-371-to-next origin/next
cd .worktree/backport-371-to-next
git switch --create backport-371-to-next
git cherry-pick -x cc3a5d19b8897d9a6e8c4f7307571c62a5bdcd36

@grische
Copy link
Contributor

grische commented Mar 27, 2024

Manually backported it to next

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Git push to origin failed for legacy with exitcode 1

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Backport failed for next, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin next
git worktree add -d .worktree/backport-371-to-next origin/next
cd .worktree/backport-371-to-next
git switch --create backport-371-to-next
git cherry-pick -x cc3a5d19b8897d9a6e8c4f7307571c62a5bdcd36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport legacy Backport to Legacy Branch backport next Backport to Next Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants