Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: add --tags to git describe in getversion.sh to include lightweighted tags #3310

Merged
merged 1 commit into from
Jul 27, 2024
Merged

scripts: add --tags to git describe in getversion.sh to include lightweighted tags #3310

merged 1 commit into from
Jul 27, 2024

Conversation

misanthropos
Copy link
Contributor

@misanthropos misanthropos commented Jul 8, 2024 •
edited
Loading

This flag allows to get the latest non annotated tag in e.g. site repositories.

@misanthropos
Since releases are tagged nowadays, getversion.sh should reflect it
98cf233 
by using git describe with --tags flag.

Signed-off-by: Richard Fröhning <misanthropos@gmx.de>
@github-actions github-actions bot added the 3. topic: build This is about the build system label Jul 8, 2024
@misanthropos misanthropos changed the title Since releases are tagged nowadays, getversion.sh should reflect it scripts: Since releases are tagged nowadays, getversion.sh should reflect it Jul 8, 2024
@neocturne
Copy link
Member

We only use annotated tags in Gluon, which are always used by git describe. So I guess this is about site repos which use lightweight tags?

@misanthropos misanthropos changed the title scripts: Since releases are tagged nowadays, getversion.sh should reflect it scripts: add --flags to git describe in getversion.sh to include lightweighted tags Jul 9, 2024
@misanthropos misanthropos changed the title scripts: add --flags to git describe in getversion.sh to include lightweighted tags scripts: add --tags to git describe in getversion.sh to include lightweighted tags Jul 9, 2024
@misanthropos
Copy link
Contributor Author

misanthropos commented Jul 9, 2024 •
edited
Loading

We only use annotated tags in Gluon, which are always used by git describe. So I guess this is about site repos which use lightweight tags?

Indeed! I stumbled upon this while using gluon-info which reported a rather old site config version.

maurerle
maurerle approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this confusing in the beginning as well.
However, I quickly learned to always use annotated tags in the site repository as well.

I would favor having this working with other tags as well - as it does not harm and makes things easier for beginners.

@blocktrron blocktrron merged commit e9acd52 into freifunk-gluon:main Jul 27, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurerle maurerle maurerle approved these changes

Assignees
No one assigned
Labels
3. topic: build This is about the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@misanthropos @neocturne @maurerle @blocktrron