Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips-mt7621: add support for Xiaomi Mi Router 4a Gigabit Edition v2 #3293

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

ChristianMiddendorf
Copy link
Contributor

@ChristianMiddendorf ChristianMiddendorf commented Jun 25, 2024

Closes #3291

  • Must be flashable from vendor firmware
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
      xiaomi-mi-router-4a-gigabit-edition-v2
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Jun 25, 2024
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is

Gluon profile name matches autoupdater image name

not ticked?

As the device does not have radio/LAN LEDs, this looks good

@maurerle
Copy link
Member

You can write

closes #3291

into the PR description, to automatically close the issue, when merged.

@ChristianMiddendorf
Copy link
Contributor Author

Why is

Gluon profile name matches autoupdater image name

not ticked?

As the device does not have radio/LAN LEDs, this looks good

Sorry, i just did not tick it after getting the string and pasting it with the proof picture. The device gives back "xiaomi-mi-router-4a-gigabit-edition-v2" as expected.

targets/ramips-mt7621 Outdated Show resolved Hide resolved
targets/ramips-mt7621 Outdated Show resolved Hide resolved
ChristianMiddendorf and others added 2 commits June 27, 2024 12:26
Co-authored-by: Tom Herbers <github@herbetom.de>
Co-authored-by: Tom Herbers <github@herbetom.de>
@ChristianMiddendorf ChristianMiddendorf changed the title Adding Support for Xiaomi Mi Router 4a Gigabit Edition v2 in Target ramips-mt7621 Adding Support for Xiaomi Mi Router 4a Gigabit Edition v2 in Target ramips-mt7621 closes #3291 Jun 27, 2024
@blocktrron blocktrron changed the title Adding Support for Xiaomi Mi Router 4a Gigabit Edition v2 in Target ramips-mt7621 closes #3291 ramips-mt7621: add support for Xiaomi Mi Router 4a Gigabit Edition v2 Jul 1, 2024
Copy link
Contributor

@herbetom herbetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally there should be only a single commit with a properly formated commit message. But in this case i thinks it's fine if whoever merges it simply does a "Squash and Merge".

Otherwise it looks okay. 👍

@blocktrron blocktrron merged commit b50007d into freifunk-gluon:main Jul 1, 2024
10 checks passed
blocktrron pushed a commit to blocktrron/gluon that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add Support for Xiaomi MI Router 4a Gigabit Edition v2
4 participants