Website #122
Merged
Website #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasberens
requested changes
Jul 16, 2024
inventory/hosts
Outdated
| @@ -35,4 +35,4 @@ download-master.berlin.freifunk.net | |||
| uisp.berlin.freifunk.net ansible_host=10.31.130.158 # New uisp VM | |||
|
|
|||
| [website] | |||
| web.berlin.freifunk.net | |||
| berlin.freifunk.net ansible_host=77.87.50.13 | |||
There was a problem hiding this comment.
please leave the correct hostname
There was a problem hiding this comment.
I thought we would use the actual domain for the website here. But sure we can use the web... domain for this.
There was a problem hiding this comment.
no, this is just the hostname for the server.
roles/ff_website/tasks/main.yml
Outdated
There was a problem hiding this comment.
Do we need this role? it seems like the 2 directories can just be created during the deployment process
There was a problem hiding this comment.
As long as the github action does not have root access, we are limited where it can create directories and put the files. But I can just place the files in a location accessible for the github user and then change the caddfile to point the webroot there.
nicolasberens
approved these changes
Jul 16, 2024
roles/ff_website/tasks/main.yml
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed the website setup. I already tested it with the test domain
web.berlin.freifunk.nethere in ansible and also in the github workflow of the website repo. Now I changed everything to the production domain.Stuff I did:
Stuff to do after merging:
berlin.freifunk.netdev.berlin.freifunk.net