Added fixed point Finite Impulse Response filter. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose that you use Scala/Java naming conventions and have the same spelling of the file name and the class name (Start with UpperCase). ChiselEnum should now be in normal Chisel, no need for use of experimental. |
added 2 commits
February 12, 2024 09:20
Fully pipelined FIR. Signed-off-by: Kevin Joly <kevin.joly@armadeus.com>
Signed-off-by: Kevin Joly <kevin.joly@armadeus.com>
|
Hello @schoeberl , I've fixed FIRFilter.scala and IIRFilter.scala filenames while I was at it. Unfortunately, ChiselEnum is still in experimental package when using 3.5.5. To overcome this, we need to upgrade this package to 3.6.0. Thanks for the review, Kevin |
|
You are right, ip-contribution is missing updates. It is on my TODO list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully pipelined FIR.