Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FST traces in verilator backend #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kammoh
Copy link

@kammoh kammoh commented Jun 24, 2019

Introducing the ability to use FST format as the output format of Verilator trace dump, instead of the VCD format. FST is a more efficient trace format introduced by the gtkwave project.
A boolean option named verilatorFstTrace is currently added to TesterOptions, but can be eventually ported into chisel-testers2 with an appropriate Annotation.

@kammoh kammoh requested a review from a team as a code owner June 24, 2019 21:07
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks pretty good. I have a couple of small problems

First: Can you please make some kind of test that demonstrates the use of the flag and that
the .fst file was created. GcdExampleSpec, for instance, test whether a .vcd was created.

Second: There are quite a few changed lines in this PR that appear to be cosmetic, different spacing.
It makes it harder for the reviewer to focus on the core change.
If you'd like to reformat things to be better style compliant that's great, but best to keep that in a separate style PR.

@chick
Copy link
Contributor

chick commented Jun 24, 2019

@ekiwi I know you have some interest in .fst format, or is your use case just for treadle

@ekiwi
Copy link

ekiwi commented Jun 25, 2019

Thanks for adding me @chick.
This looks like a great pull request (once the formatting issues are addressed).

Do you know if the verilator version is available in the backend? As far as I remember the fst support was only added in verilator 4.0, thus it might be good to catch any versions below that and fail with a useful error message to the user, telling them to update their verilator version if they need fst output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants