Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hd_ticket.py #1556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update hd_ticket.py #1556

wants to merge 2 commits into from

Commits on Sep 12, 2023

  1. Update hd_ticket.py

    frappe.get_value does not guarantee returned  fields order from database, we have situations where values are reversed between enable_restrictions and ignore_restrictions (one's take the other field value)
    
    `value = get_list(  <============== IN FRAPPE THIS DOES NOT GUARANTEE FIELDS ORDER
    			doctype,
    			filters=filters,
    			fields=fields,
    			debug=debug,
    			limit_page_length=1,
    			parent=parent,
    			as_dict=as_dict,
    		) 
    
    	if as_dict:
    		return value[0] if value else {}
    
    	if not value:
    		return
    
    	return value[0] if len(fields) > 1 else value[0][0]
    `
    
    fixing by reading the result
    ovresko authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    18a2ba7 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Update hd_ticket.py

    Fix spelling "restrictions"
    ovresko authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f633ea1 View commit details
    Browse the repository at this point in the history