Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preset filters #1289

Closed
wants to merge 1 commit into from

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jun 29, 2023

Works only with v15 (develop), hence

  • Have to drop now
  • Can be reopened in the future

@ssiyad ssiyad added the enhancement New feature or request label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.33 🎉

Comparison is base (75e655f) 12.87% compared to head (4a31221) 13.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
+ Coverage   12.87%   13.21%   +0.33%     
==========================================
  Files          52       53       +1     
  Lines        1848     1900      +52     
==========================================
+ Hits          238      251      +13     
- Misses       1610     1649      +39     
Impacted Files Coverage Δ
helpdesk/__init__.py 100.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...hd_desk_account_request/hd_desk_account_request.py 0.00% <ø> (ø)
...k/doctype/hd_escalation_rule/hd_escalation_rule.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 21.86% <ø> (-0.66%) ⬇️
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <ø> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <ø> (ø)
helpdesk/utils.py 39.13% <ø> (+39.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad closed this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant