Wait until the database is reachable in job-create-site

[MohammedNoureldin]

• Wait for the database in the init container to become reachable before trying to create a new site. Without waiting there is a race condition that pops up occasionally which makes the creation of the site fail.

• Exit the main container of the job if any error happens by adding set -e. At the moment the container exists with the return code 0, even if the site was not successfully created. This is because the last command in the entrypoint is an rm -f which always exits with 0.

helm/erpnext/templates/job-create-site.yaml

Line 104 in 275c25f

;rm -f currentsite.txt

Related to #205

Actually exiting the container with the correct exit code is enough to fix the issue if the job is configured to restart if failed. Though, waiting for the database in the beginning is cleaner.

[MohammedNoureldin]

I also added the ability to attach annotations, because one possible workaround in case of using ArgoCD could have been using ArgoCD waves. However, because the chart does not include annotations for this job, this solution is not yet possible.

[MohammedNoureldin]

I have just finished testing the pull request by deploying it multiple/many times. The issue seems to be properly fixed now. At least it is not reproduceable in this branch anymore.

[MohammedNoureldin]

I fixed a few minor issues and did some enhancements.