#1402 Environment variables for custom image #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix the pre-commit / lint |
|
Done :), I think so |
TheRealJim1
pushed a commit
to TheRealJim1/frappe_docker
that referenced
this pull request
Jul 26, 2024
* chore: enhance compose.yaml with variables for customize * chore: use default blank values for db and redis variables in compose.yaml * chore: Use env var for HTTP(S) publish ports in overrides * docs: explain use of environment variables for image customization * chore: use ERPNEXT_VERSION as default * docs: fixed spelling errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This pull request addresses the need highlighted in the issue for enhancing the customization process within Frappe Docker deployments. The current method of manually modifying the
compose.yamlfile for custom applications, as described in the issue, can potentially lead to challenges in version control and file integrity.To alleviate this, I propose the introduction of environment variables, including
CUSTOM_IMAGE,CUSTOM_TAG,PULL_POLICY,HTTP_PUBLISH_PORTandHTTPS_PUBLISH_PORT, which users can leverage to customize their deployments seamlessly. This approach not only simplifies the customization process but also enhances the maintainability and consistency of Frappe Docker configurations.By incorporating this feature, users can define their custom image names and tags directly through environment variables, facilitating smoother deployments without compromising the integrity of configuration files. Further details and discussions regarding the necessity and implementation of this enhancement are available in the associated issue.