Fixed binding issues with slices (#118)

* Fixed binding issues with slices Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Removed unnecessary changes Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
flyteorg · Mar 4, 2022 · 8aba39c · 8aba39c
1 parent d304944
commit 8aba39c
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 12 deletions.
diff --git a/cli/pflags/api/generator.go b/cli/pflags/api/generator.go
@@ -342,6 +342,9 @@ func discoverFieldsRecursive(ctx context.Context, workingDirPkg string, typ *typ
 		case *types.Slice:
 			logger.Infof(ctx, "[%v] is of a slice type with default value [%v].", tag.Name, tag.DefaultValue)
 			defaultValue := tag.DefaultValue
+			if len(defaultValueAccessor) > 0 {
+				defaultValue = appendAccessors(defaultValueAccessor, fieldPath, variable.Name())
+			}
 
 			f, err := buildFieldForSlice(logger.WithIndent(ctx, indent), t, tag.Name, variable.Name(), tag.Usage, defaultValue, bindDefaultVar)
 			if err != nil {

diff --git a/cli/pflags/api/testdata/testtype.go b/cli/pflags/api/testdata/testtype.go
diff --git a/cli/pflags/api/testdata/testtype_bind.go b/cli/pflags/api/testdata/testtype_bind.go
diff --git a/cli/pflags/api/testdata/testtype_bind_test.go b/cli/pflags/api/testdata/testtype_bind_test.go
diff --git a/cli/pflags/api/testdata/testtype_test.go b/cli/pflags/api/testdata/testtype_test.go