Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim docs #1709

Merged
merged 9 commits into from
Jul 30, 2024
Merged

nim docs #1709

merged 9 commits into from
Jul 30, 2024

Conversation

samhita-alla
Copy link
Contributor

@samhita-alla samhita-alla commented Jul 19, 2024

Fixes flyteorg/flyte#5478

This PR documents NIM wrapper for serving optimized model containers in a Flyte task.

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@samhita-alla samhita-alla marked this pull request as ready for review July 22, 2024 13:54
neverett
neverett previously approved these changes Jul 24, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM

examples/nim_wrapper/README.md Outdated Show resolved Hide resolved
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@samhita-alla
Copy link
Contributor Author

@neverett could you approve again?

@samhita-alla samhita-alla merged commit a23e1b7 into master Jul 30, 2024
54 of 57 checks passed
@samhita-alla samhita-alla deleted the add-nim-docs branch July 30, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration] NIM
2 participants