Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make k8 messages collapsible on node execution details panel #868

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jsonporter
Copy link
Contributor

This PR makes the k8 messages on the Node Execution Details panel collapsible

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Jason Porter <jason@union.ai>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.74%. Comparing base (7fff412) to head (a9872c3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   54.74%   54.74%           
=======================================
  Files         578      578           
  Lines       15149    15149           
  Branches     2764     2764           
=======================================
  Hits         8293     8293           
  Misses       6856     6856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsonporter jsonporter merged commit 364191e into master Apr 24, 2024
12 checks passed
@jsonporter jsonporter deleted the json/execution-details-k8 branch April 24, 2024 17:44
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants