Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [BUG] Flyteconsole not showing latest LaunchPlan details #867

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ursucarina
Copy link
Contributor

TL;DR

Fetches latest Entity Details launch plan

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Switched EntityDetails to useLatestLaunchPlans hook

Tracking Issue

flyteorg/flyte#5271

Follow-up issue

NA

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina enabled auto-merge (squash) April 24, 2024 15:39
@ursucarina ursucarina requested review from a team, FrankFlitton and jsonporter and removed request for a team April 24, 2024 15:42
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.74%. Comparing base (7bf5a25) to head (79fc964).

Files Patch % Lines
...s-console/src/components/Entities/EntityInputs.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   54.74%   54.74%   -0.01%     
==========================================
  Files         578      578              
  Lines       15153    15149       -4     
  Branches     2767     2764       -3     
==========================================
- Hits         8296     8293       -3     
+ Misses       6857     6856       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ursucarina ursucarina merged commit 7fff412 into master Apr 24, 2024
10 of 12 checks passed
@ursucarina ursucarina deleted the carina/5271 branch April 24, 2024 16:31
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants