Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid premature CRD Deletion #5787

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RRap0so
Copy link
Contributor

@RRap0so RRap0so commented Sep 30, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.57%. Comparing base (66ff152) to head (bc82a62).

❗ There is a different number of reports uploaded between BASE (66ff152) and HEAD (bc82a62). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (66ff152) HEAD (bc82a62)
unittests-flytectl 1 0
unittests-flyteadmin 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5787      +/-   ##
==========================================
- Coverage   36.31%   29.57%   -6.74%     
==========================================
  Files        1304      842     -462     
  Lines      110048    83421   -26627     
==========================================
- Hits        39964    24672   -15292     
+ Misses      65928    56145    -9783     
+ Partials     4156     2604    -1552     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.93% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant