Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster pool assignment validation #5778

Closed
wants to merge 1 commit into from

Conversation

iaroslav-ciupin
Copy link
Contributor

Tracking issue

Why are the changes needed?

When client explicitly provides a cluster pool, we must ensure its compatible with existing project/domain mapping configs.
Without this validation, execution will be scheduled and may fail with creepy very non-intuitive errors during runtime.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 242 lines in your changes missing coverage. Please review.

Project coverage is 36.39%. Comparing base (0d1583e) to head (2d0032c).
Report is 2 commits behind head on union/upstream.

Files with missing lines Patch % Lines
flyteadmin/pkg/manager/mocks/resource_interface.go 0.00% 242 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           union/upstream    #5778      +/-   ##
==================================================
- Coverage           36.46%   36.39%   -0.08%     
==================================================
  Files                1309     1310       +1     
  Lines              110464   110700     +236     
==================================================
+ Hits                40284    40290       +6     
- Misses              66011    66242     +231     
+ Partials             4169     4168       -1     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.20% <8.33%> (-0.62%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.16% <ø> (ø)
unittests-flyteplugins 53.32% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (+<0.01%) ⬆️
unittests-flytestdlib 55.84% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants