-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyte docs overhaul (phase 1) #5772
Open
neverett
wants to merge
16
commits into
master
Choose a base branch
from
nikki/docs/flyte-docs-overhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,860
−6,182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
This was referenced Sep 24, 2024
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
==========================================
- Coverage 36.31% 36.31% -0.01%
==========================================
Files 1304 1304
Lines 110048 110048
==========================================
- Hits 39964 39963 -1
- Misses 65928 65929 +1
Partials 4156 4156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
neverett
changed the title
[WAIT TO MERGE] Flyte docs overhaul - phase 1
Flyte docs overhaul (phase 1)
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
This is phase 1 in a multi-phase project to overhaul the Flyte docs to make them easier to maintain and contribute to, and more useful and usable for readers.
To test these changes locally, you will need to do the following:
conda env update --file monodocs-environment.lock.yaml
nikki/docs/refresh
branchFLYTESNACKS_LOCAL_PATH
environment variable to the location of your local copy of flytesnacksNote: The monodocs build will fail for this PR until the linked flytesnacks PR is merged.
Why are the changes needed?
These changes make the Flyte docs easier to maintain and contribute to and lay the groundwork for phase 2 of the Flyte docs overhaul project, in which we'll significantly update the content itself to be more useful, usable, and accurate for readers. They also bring the Flyte docs into closer alignment with Union docs by switching the theme from furo to pydata.
What changes were proposed in this pull request?
Note: There are two issues left from phase 1 that I am moving to phase 2 in order to not block the rest of phase 1 work from being completed and merged:
Screenshots from local build
Landing page
User guide section
Additional sections
How was this patch tested?
Tested locally.
Check all the applicable boxes
Related PRs
flyteorg/flytesnacks#1726
Docs link
TK