-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flyte][3][flytepropeller][Attribute Access][flytectl] Binary IDL With MessagePack #5763
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5763 +/- ##
==========================================
+ Coverage 36.30% 36.35% +0.05%
==========================================
Files 1305 1304 -1
Lines 110000 110112 +112
==========================================
+ Hits 39932 40032 +100
- Misses 65912 65921 +9
- Partials 4156 4159 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
t.Run("Generic", func(t *testing.T) { | ||
literalVal := map[string]interface{}{ | ||
"x": 1, | ||
"y": "ystringvalue", | ||
} | ||
var literalType = &core.LiteralType{Type: &core.LiteralType_Simple{Simple: core.SimpleType_STRUCT}} | ||
lit, err := MakeLiteralForType(literalType, literalVal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Tracking Issue
Issue #5318
Why are these changes needed?
flytectl
to create and get executions.Note: This PR includes handling of primitive types, Flyte types, and dataclasses.
What changes are proposed in this pull request?
Attribute Access
msgpack
bytes inBinary Literal
.Binary Literal
.flytectl
flytectl
, serialize it tomsgpack
bytes and create a binary scalar directly.This version is more concise, avoids redundant words, and clarifies the structure a bit.
How was this patch tested?
Attribute Access
unit tests and remote execution
flytectl
command line
get_task.yaml
Setup process
single binary
Screenshots
Local Execution
Remote Execution
Check all the applicable boxes