Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
Update role, rolebinding, (cluster...) to v1 apis
Browse files Browse the repository at this point in the history
The cluster rbac and rbac roles in the helm chart templates can still
reference the old v1beta1 rbac.authorization.k8s.io API, which must be
removed in preparation for K8s 1.22.

The CRD changes already meant that Kubernetes 1.16+ was required in the
(next) newest version of Helm Operator.

This change requires K8s 1.8+ so, while we can mention it separately in
the release notes, it does not add any additional functional requirement
for the users, as they must already upgrade to this version or greater.

Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
  • Loading branch information
yebyen committed Jun 21, 2021
1 parent 9a4e753 commit 4a3a81c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions chart/helm-operator/templates/rbac-role.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if and .Values.rbac.create (eq .Values.clusterRole.create false) -}}
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: {{ template "helm-operator.fullname" . }}
Expand All @@ -17,7 +17,7 @@ rules:
verbs:
- '*'
---
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: {{ template "helm-operator.fullname" . }}
Expand Down
4 changes: 2 additions & 2 deletions chart/helm-operator/templates/rbac.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if and .Values.rbac.create (eq .Values.clusterRole.create true) -}}
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: {{ template "helm-operator.clusterRoleName" . }}
Expand All @@ -20,7 +20,7 @@ rules:
verbs:
- '*'
---
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ template "helm-operator.clusterRoleName" . }}
Expand Down

0 comments on commit 4a3a81c

Please sign in to comment.