CCOL-2039: Global consumer configurations for replace_association & bulk_id_generation #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelpereira
changed the title
dorner
requested changes
Dec 1, 2023
|
|
||
| default = MyConfigConsumer2.config | ||
| expect(default[:replace_associations]).to eq(true) | ||
| expect(default[:bulk_import_id_generator].call).to eq('global') |
There was a problem hiding this comment.
This doesn't actually test that the generator is called when expected (i.e. during the batch updates). Ideally you'd make this change in e.g. the mass updater spec.
dorner
requested changes
Dec 1, 2023
| context 'with a class defined bulk_import_id_generator' do | ||
|
|
||
| before(:each) do | ||
| consumer_class.config[:bulk_import_id_generator] = proc { 'custom' } |
There was a problem hiding this comment.
You should still define the global one here - this should override the global.
lionelpereira
force-pushed
the
CCOL-2039-configuration
branch
from
be07ca9
to
4876045
Compare
dorner
approved these changes
Dec 4, 2023
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: