Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCOL-2039: Support for post processing and custom batch generation #203

Closed
wants to merge 5 commits into from

Conversation

lionelpereira
Copy link
Collaborator

@lionelpereira lionelpereira commented Nov 27, 2023

Pull Request Template

Description

  • Include current monkey patches currently implemented in Item Platform
  1. Return valid records saved during consumption for further processing
  2. Return records not valid for consumption for further processing
  3. Allow global consumer batch id generator proc for use in bulk imports
  4. Allow global consumer replace_associations configuration for use in bulk imports
  5. Allow individual consumers to specify batch id generator proc for use in bulk imports
  6. Use a record lookup entity for use in record attribute construction

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dorner
Copy link
Member

dorner commented Nov 27, 2023

@lionelpereira can you provide more context for this? What's the problem it's trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants