#195 Fix buffer overflow exception handling #197

2rba · 2023-07-18T16:35:20Z

Description

@logger.error(Deimos::KafkaMessage.decoded(messages)) in the rescue block fails to decode the message and causes wrong exception raised
This PR:

fixes message decoding
adds rescue block around decoding call to make sure if decode is misconfigured that does not interfere with original exception

Fixes #195

tests added

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

2rba · 2023-07-18T16:36:19Z

spec/utils/db_producer_spec.rb

@@ -308,35 +309,6 @@
      Deimos.unsubscribe(subscriber)
    end

-    it 'should delete messages on buffer overflow' do


moved to the context block above

dorner · 2023-07-18T20:32:30Z

Thanks so much for the contribution!

flipp-oss#195 Fix buffer overflow exception handling

200b9d4

2rba commented Jul 18, 2023

View reviewed changes

dorner approved these changes Jul 18, 2023

View reviewed changes

dorner merged commit 6e190c0 into flipp-oss:master Jul 18, 2023
5 checks passed