Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --redis flag #52

Merged
merged 1 commit into from
Sep 11, 2024
Merged

add --redis flag #52

merged 1 commit into from
Sep 11, 2024

Conversation

ababino
Copy link
Contributor

@ababino ababino commented Sep 10, 2024

πŸ“ Summary

edit bidcollect.go, bid-processor.go and bidcollector.go to accept the --redis falg

β›± Motivation and Context

Since PR50, the default behavior of the bid collector is to assume that there's a redis service running, even if we do not add the --redis falg.

If you run:

go run . service bidcollect --data-api --ultrasound-stream --all-relays

You will get this error:

failed to create bid collector                error="dial tcp [::1]:6379: connect: connection refused"
exit status 1

A workaround is to set --redis-addr ""

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test
  • go mod tidy

make lint yields several warnings an errors, non of them seem to be related to this PR

Copy link
Contributor

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@metachris metachris merged commit d9fd104 into flashbots:main Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants