Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(startup): Remove static_file_provider checks create_provider_factory #207

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ryanschneider
Copy link
Contributor

@ryanschneider ryanschneider commented Oct 2, 2024

📝 Summary

This PR removes the calls to static_file_provider().get_highest_static_file_block(..) since it appears we no longer actively use the static file provider in our code.

💡 Motivation and Context

As far as I can tell, we no longer really use the static_file_provider inside the ProviderFactoryReopener, but the check in create_provider_factory causes circular dependencies related to #199 or ethpandaops/ethereum-package#786.


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ryanschneider ryanschneider marked this pull request as ready for review October 2, 2024 20:38
Copy link

github-actions bot commented Oct 2, 2024

Benchmark results for e00b981

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/e00b981-412ff88/report/index.html

Date (UTC) 2024-10-02T20:39:05+00:00
Commit e00b981fd6aa63e8f2c5c78e8246229a50422e5d
Base SHA 412ff880b939030e81ea068eb2cd8ee4fffe79ba

Significant changes

Benchmark Mean Status
MEV-Boost SubmitBlock serialization/JSON encoding 57.87% Performance has degraded.

Copy link
Contributor

@dvush dvush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until its clear that its needed so we don't merge accidentally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants