Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle hash for redistribution #193

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Bundle hash for redistribution #193

merged 2 commits into from
Sep 30, 2024

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Sep 27, 2024

Adds bundle hash to redistribution output

output json diff:

<               "Bundle": {
<                 "uuid": "$UUID",
<                 "hash": "$HASH"
<               }
---
>               "Bundle": "$UUID"

Copy link

github-actions bot commented Sep 27, 2024

Benchmark results for 763b584

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/763b584-10495ea/report/index.html

Date (UTC) 2024-09-27T17:00:55+00:00
Commit 763b5840f7bc43e2a4315578c56c0c98ab863b62
Base SHA 10495ea9ff3441da93792e9e0ee72abec74e24af

Significant changes

Benchmark Mean Status
MEV-Boost SubmitBlock serialization/JSON encoding -35.85% Performance has improved.

Copy link
Contributor

@ryanschneider ryanschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! One question though: eventually we want to add additional "metadata" like the sender field as well (which would be either the bundle signing key or the tx sender depending on if the order is only a single tx or not). Do we think we'd continue to add this new metadata to ExtendedOrderId as well? Perhaps we could end up with/ something like:

pub enum ExtendedOrderId {
    Tx { hash: B256, sender: Address },
    Bundle { uuid: Uuid, hash: B256, sender: Address },
    ShareBundle{ hash: B256, sender: Address },
}

And I think ShareBundle might want an tx_hash: Option<B256> for single-tx sbundles (since one of the desires is for end users to be able to lookup their refunds via sent tx hashes, and IIUC private txs get converted to single-tx sbundles).

Anyways not advocating for doing any of this now, just wanted to get the idea down and make sure we're not backing ourselves into a corner by putting the hash in the OrderId!

@dvush dvush merged commit 0c0985b into develop Sep 30, 2024
5 checks passed
@dvush dvush deleted the bundle_hash_redistr branch September 30, 2024 11:21
astarinmymind pushed a commit that referenced this pull request Oct 3, 2024
Adds bundle hash to redistribution output

output json diff:

```
<               "Bundle": {
<                 "uuid": "$UUID",
<                 "hash": "$HASH"
<               }
---
>               "Bundle": "$UUID"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants