Wait for rbuilder running before running integration test #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for
|
| Date (UTC) | 2024-08-28T13:53:28+00:00 |
| Commit | b426cedd0bb8d46ca5fce144cea503d82ad2044e |
| Base SHA | 7cb7f3154d2fddcc51c87f78eb4b91c520ac7f8c |
Significant changes
None
liamaharon
approved these changes
Aug 28, 2024
Comment on lines
+100
to
+117
| loop { | ||
| if start.elapsed().as_secs() > 10 { | ||
| return Err(PlaygroundError::Timeout); | ||
| } | ||
|
|
||
| // from the log file, check if the server has started | ||
| // by checking if the string "RPC server job: started" is present | ||
| let mut file = File::open(&log_path).map_err(|_| PlaygroundError::SetupError)?; | ||
| let mut contents = String::new(); | ||
| file.read_to_string(&mut contents) | ||
| .map_err(|_| PlaygroundError::SetupError)?; | ||
|
|
||
| if contents.contains("RPC server job: started") { | ||
| break; | ||
| } | ||
|
|
||
| thread::sleep(std::time::Duration::from_millis(100)); | ||
| } |
There was a problem hiding this comment.
Something like this would be more idiomatic and avoid spamming io ops https://github.com/jmagnuson/linemux. I wouldn't call it a "must have" though.
There was a problem hiding this comment.
Yeah, I was hoping to do an http request to check some health check endpoint. But could not make it work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The new integration test introduced in #143 requires the rbuilder to be running to work. However, the playground setup was not waiting for it. This PR fixes that. It adds a loop after the rbuilder creation that checks in the output log for a specific log "RPC server job: started" that signals that the builder is running and the test can start.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test