Isolate extra data modification to builder module #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmel
changed the title
dmarzzz
reviewed
Sep 10, 2024
avalonche
reviewed
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra data set by miner configuration should only be set when builder is building payloads to serve.
op-node deriver forces forkchoiceUpdate when pendingSafeL2Head.Number == unsafeL2Head.Number, which causes op-geth to build block with different extra data than it was supposed to, forking the chain.
More investigation is needed when above condition happens. This bug was found when starting the chain from fresh on the devnet, and the op-node seems to force insert some early blocks after genesis block.
This PR is to isolate the extra data modification to the builder module only.