Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DebugInfo][test] Fix tests for LLVM 19 compatibility #1455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryanpkc
Copy link
Collaborator

@bryanpkc bryanpkc commented Oct 2, 2024

Upstream LLVM has eliminated debug intrinsics like @llvm.dbg.value() and @llvm.dbg.declare(), and replaced them with DPValue objects that are printed as #dbg_value() and #dbg_declare(). This patch modifies the FileCheck patterns in the tests to match, and make them require the llvm-19 feature.

Upstream LLVM has eliminated debug intrinsics like @llvm.dbg.value()
and @llvm.dbg.declare(), and replaced them with DPValue objects that
are printed as #dbg_value() and #dbg_declare(). This patch modifies
the FileCheck patterns in the tests to match, and make them require
the "llvm-19" feature.
Copy link
Collaborator

@alokkrsharma alokkrsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants