[flang2] Generate loads of complex variables with correct alignment #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flang2 calls the function make_load() to create various types of load instructions in the LLVM IR output. The function accepts a "flags" argument of type LL_InstrListFlags which should encode the alignment of the load, among other things. Apparently, for the IL_LDSCMPLX, IL_LDDCMPLX, and IL_LDQCMPLX opcodes, the flags had never been computed correctly. This patch makes such loads consistent with loads of other types, and also adds a test case.
pawosm-arm
reviewed
Jul 23, 2024
@pawosm-arm Yes, it is intentional. |
pawosm-arm
approved these changes
Jul 23, 2024
shivaramaarao
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flang2 calls the function
make_load()to create various types of load instructions in the LLVM IR output. The function accepts aflagsargument of typeLL_InstrListFlagswhich should encode the alignment of the load, among other things. Apparently, for theIL_LDSCMPLX,IL_LDDCMPLX, andIL_LDQCMPLXopcodes, the flags had never been computed correctly. This patch makes such loads consistent with loads of other types, and also adds a test case.