[flang2] byval and sret attributes should have associated types #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanpkc
force-pushed
the
fix-byval-sret-attributes
branch
from
669cb52
to
6fb13b9
Compare
bryanpkc
force-pushed
the
fix-byval-sret-attributes
branch
3 times, most recently
from
6a97a84
to
f8fa3a7
Compare
When the return value of the function is a structure, the ABI might require that the caller pass the structure into the function call as an implicit input argument; in such cases the generated IR for the argument will have the sret attribute. Similarly, pass-by-value arguments are given the byval attribute in the IR. Since the adoption of opaque pointers, such attributes are required to be accompanied with the pointee type. This patch fixes flang2 to generate correct IR for such argument/return types. Co-authored-by: Liuyunlong <liuyunlong16@huawei.com>
|
@pawosm-arm @shivaramaarao This is ready for review. |
pawosm-arm
reviewed
Sep 22, 2023
pawosm-arm
approved these changes
Sep 23, 2023
|
@shivaramaarao gentle ping |
shivaramaarao
approved these changes
Sep 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the return value of the function is a structure, the ABI might require that the caller pass the structure into the function call as an implicit input argument; in such cases the generated IR for the argument will have the sret attribute. Similarly, pass-by-value arguments are given the byval attribute in the IR. Since the adoption of opaque pointers, such attributes are required to be accompanied with the pointee type. This patch fixes flang2 to generate correct IR for such argument/return types.
Fixes #1419.