Fix failures for imports with LLVM-17 #1414
Merged
+52
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symptom: Compilation of any Fortran program with imports (USE statement) fails with assert in compiler backend. Diagnosis: LLVM-17 expects imports list in retainedNode field of DISubprogram wihch while Flang is still generating it as imports field of DICompilationUnit. Fix: Flang is now updated to new IR as expected by LLVM-17.
alokkrsharma
requested review from
pawosm-arm,
kiranchandramohan,
bryanpkc,
shivaramaarao and
bhuvanendrakumarn
pawosm-arm
approved these changes
Aug 8, 2023
bryanpkc
reviewed
Aug 9, 2023
tools/flang2/flang2exe/lldebug.cpp
Outdated
| @@ -4107,7 +4114,8 @@ lldbg_function_end(LL_DebugInfo *db, int func) | |||
|
|
|||
| static LL_MDRef | |||
| lldbg_create_imported_entity(LL_DebugInfo *db, SPTR entity_sptr, SPTR func_sptr, | |||
| IMPORT_TYPE entity_type, LL_MDRef elements_mdnode) | |||
| IMPORT_TYPE entity_type, LL_MDRef elements_mdnode, | |||
| LL_MDRef imported_list) | |||
There was a problem hiding this comment.
Nit: The parameter declaration is not left-aligned with the previous line.
bryanpkc
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom: Compilation of any Fortran program with imports (USE statement) fails with assert in compiler backend.
Diagnosis: LLVM-17 expects imports list in retainedNode field of DISubprogram wihch while Flang is still generating it as imports field of DICompilationUnit.
Fix: Flang is now updated to new IR as expected by LLVM-17.