[LLVM16][build] Specify LLVM_MAIN_SRC_DIR when running build-flang.sh #1403
+34
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawosm-arm
requested changes
Jul 3, 2023
pawosm-arm
approved these changes
Jul 3, 2023
bryanpkc
force-pushed
the
fix-llvm16-flang-tests
branch
from
a19fb52
to
e3971d9
Compare
Otherwise Classic Flang's CMakeLists.txt will be unable to find llvm-lit and cannot generate test-related goals, e.g. `check-all`. Also fix a typo in build-flang.sh that prevented the option from being passed to CMake correctly.
|
@pawosm-arm I added a couple more commits. Do they look okay to you? |
pawosm-arm
reviewed
Jul 4, 2023
bryanpkc
force-pushed
the
fix-llvm16-flang-tests
branch
from
091f297
to
78a7a0b
Compare
Yes, they do |
…e tree Support the LLVM_MAIN_SRC_DIR variable which, if set to the LLVM source tree, allows CMake to locate llvm-lit and generate the "check-libpgmath" goal. Also update build-flang.sh to use the variable when building libpgmath. Also modified helpers in runtime/libpgmath/cmake/modules/LibmathUtils.cmake, e.g. libpgmath_say, libpgmath_warning_say, to print all given arguments instead of only the first named argument. This allows callers to break long strings into multiple lines, resulting in better-formatted code.
|
Merging CI-only PR with one approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise Classic Flang's
CMakeLists.txtwill be unable to findllvm-litand cannot generate test-related goals, e.g.check-all.Also fix a typo in
build-flang.shthat prevented the option from being passed to CMake correctly.Also add support for the same variable to libpgmath's CMakeLists.txt, as well as
scripts/build_flang.py.Also modify helpers in
runtime/libpgmath/cmake/modules/LibmathUtils.cmake, e.g.libpgmath_say,libpgmath_warning_say, to print all given arguments instead of only the first named argument. This allows callers to break long strings into multiple lines, resulting in better-formatted code.