Add Windows support to openmp_examples tests #1370
Merged
+241
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdusnoki
force-pushed
the
openmp_examples
branch
from
3546844
to
2fb0721
Compare
tdusnoki
changed the title
bryanpkc
approved these changes
Jul 19, 2023
pawosm-arm
reviewed
Jul 19, 2023
| @@ -5,5 +5,5 @@ | |||
|
|
|||
| # Shared lit script for each tests. Run bash commands that run tests with make. | |||
|
|
|||
| # RUN: KEEP_FILES=%keep FLAGS=%flags TEST_SRC=%s MAKE_FILE_DIR=%S/.. bash %S/runmake | tee %t | |||
| # RUN: env KEEP_FILES=%keep FLAGS=%flags TEST_SRC=%/s MAKE_FILE_DIR=%/S/.. bash %/S/runmake | tee %/t | |||
There was a problem hiding this comment.
From https://llvm.org/docs/CommandGuide/lit.html#substitutions : Just like %s and %S but \ is replaced by /.
There was a problem hiding this comment.
I presume this couldn't be done any nicer way...
There was a problem hiding this comment.
Yeah, mingw64 bash is a bit picky about path. Unfortunately, We haven't found other way how we can force Posix slashes on Windows. that's why we decided to use predefined lit substitution. Despite it results really huge changes in tests.
pawosm-arm
approved these changes
Jul 19, 2023
| @@ -5,5 +5,5 @@ | |||
|
|
|||
| # Shared lit script for each tests. Run bash commands that run tests with make. | |||
|
|
|||
| # RUN: KEEP_FILES=%keep FLAGS=%flags TEST_SRC=%s MAKE_FILE_DIR=%S/.. bash %S/runmake | tee %t | |||
| # RUN: env KEEP_FILES=%keep FLAGS=%flags TEST_SRC=%/s MAKE_FILE_DIR=%/S/.. bash %/S/runmake | tee %/t | |||
There was a problem hiding this comment.
I presume this couldn't be done any nicer way...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.