You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kaadam You may need to rebase this branch and make the same changes to new tests that were added since the creation of this PR.
Thanks for the review Bryan. Updated the PR.
New PRs have been merged since your rebase. Please rebase again and update any new test. When this PR is merged, will we be able to run tests on a Windows runner in the GitHub CI workflow? Otherwise it will be too easy to break testing on Windows.
The tests direct their outputs to a file and stdout by using tee,
on Windows seems we have a buffering issue since the results of the test
doesn't appeare on stdout. As workaround we used fflush in check.c.
New PRs have been merged since your rebase. Please rebase again and update any new test. When this PR is merged, will we be able to run tests on a Windows runner in the GitHub CI workflow? Otherwise it will be too easy to break testing on Windows.
Thanks for your comment. I've updated the PR. Approx. less than the half of the tests are still failing on Windows. I'm not sure the recent number of the failures (enclose later). Basically we can enable the test running, but before might be worth to skip them for Windows. Unfortunately I have no time to fix the remaining failures, but I can open issue for them.
windowsAdd this to all windows specific issues or PRs
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bryanpkc
changed the title
No description provided.