Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implicit plugins #900

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Implicit plugins #900

wants to merge 4 commits into from

Conversation

kmandrika
Copy link
Contributor

Description here...

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@kmandrika kmandrika changed the title Implicit plugins [WIP] Implicit plugins Sep 12, 2024
kmandrika
kmandrika commented Sep 12, 2024
View reviewed changes
js/core/src/plugin.ts Outdated
@@ -25,12 +25,25 @@ export interface Provider<T> {
value: T;
}

export enum PluginProvidesType {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this is wrong, will fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to work as a bitmask

@pavelgj
Copy link
Collaborator

pavelgj commented Sep 13, 2024

There are massive changes w.r.t. @apascal07 is working on in next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apascal07 apascal07 Awaiting requested review from apascal07

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmandrika @pavelgj