fix: cargo test for non-root users #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullr0ute
reviewed
Feb 29, 2024
|
Opened a PR to update the sysinfo crate |
mmartinv
force-pushed
the
fix-cargo-test-non-root
branch
from
e70dc32
to
943c874
Compare
mmartinv
force-pushed
the
fix-cargo-test-non-root
branch
from
943c874
to
4b2bab2
Compare
7flying
reviewed
Feb 29, 2024
mmartinv
force-pushed
the
fix-cargo-test-non-root
branch
5 times, most recently
from
861738d
to
2577761
Compare
Add `system_info` module to `utils` containing functions that gather information from current user Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Do not run tests that require root. The tests requiring superuser privileges are marked as ignored and will display a message on how to actually run those tests: ``` [root@localhost]# cargo test -- --ignored ``` An additional test is added to check that the effective user name is actually root before trying to run the commands. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
mmartinv
force-pushed
the
fix-cargo-test-non-root
branch
from
2577761
to
1276c27
Compare
Use `system_info` mod functions to gather the current user name. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
mmartinv
force-pushed
the
fix-cargo-test-non-root
branch
from
1276c27
to
76c7773
Compare
miabbott
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system_infomodule toutilssystem_infomod functions to gather the current user nameFixes: #630