fix: vendored tarfile creation #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartinv
changed the title
mmartinv
force-pushed
the
fix-vendored-tarfile-creation
branch
2 times, most recently
from
9c90237
to
fcb6fbc
Compare
mmartinv
force-pushed
the
fix-vendored-tarfile-creation
branch
from
fcb6fbc
to
f1d74cb
Compare
mmartinv
force-pushed
the
fix-vendored-tarfile-creation
branch
from
f1d74cb
to
a8cc4d9
Compare
7flying
reviewed
Mar 5, 2024
7flying
reviewed
Mar 5, 2024
Use `cargo-vendor-filtering`[1] to filter uneeded crates when vendoring. [1] https://github.com/coreos/cargo-vendor-filterer Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Add missing patch to `rpmbuild/SOURCES` dir that makes the build to fail in Fedora and do not copy unneeded files. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Use %autosetup macro to uncompress all the sources and apply patches automatically when needed. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
mmartinv
force-pushed
the
fix-vendored-tarfile-creation
branch
from
a8cc4d9
to
a931428
Compare
Generate the vendor tar file only for RHEL/CentOS builds and remove `Source1` and the comment above in fedora as we don't need vendoring in this case. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Install the build depencencies for `fido-device-onboard` package so the build does not fail. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Add the missing `sqlite-devel` RPM build dependency. Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Fix RPM build warnings:
File listed twice: /etc/fdo/keys
absolute symlink: /usr/libexec/fdo/fdo-owner-tool -> /usr/bin/fdo-owner-tool
absolute symlink: /usr/libexec/fdo/fdo-admin-tool -> /usr/bin/fdo-admin-tool
Signed-off-by: Miguel Martín <mmartinv@redhat.com>
mmartinv
force-pushed
the
fix-vendored-tarfile-creation
branch
from
a931428
to
e7f7d1f
Compare
nullr0ute
reviewed
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file listed twiceandabsolute symlinkrpm build warningsFixes: #514