Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how we can remove more windows related crates when vendoring #514

Closed
7flying opened this issue Jun 21, 2023 · 1 comment · Fixed by #634
Closed

Investigate how we can remove more windows related crates when vendoring #514

7flying opened this issue Jun 21, 2023 · 1 comment · Fixed by #634
Assignees
@mmartinv
Labels
dependencies Pull requests that update a dependency file distro Distro related things such as packaging good first issue Good for newcomers jira

Comments

@7flying
Copy link
Contributor

7flying commented Jun 21, 2023 •
edited
Loading

See discussion at #513 , we do have still some windows crates that we ship when vendoring, but we might be able to remove them.

If we can't, we should consider opening issues on other projects so that the windows target becomes optional.
@7flying 7flying added the jira label Jun 21, 2023
@nullr0ute nullr0ute added good first issue Good for newcomers dependencies Pull requests that update a dependency file distro Distro related things such as packaging labels Jun 22, 2023
@mmartinv mmartinv self-assigned this Feb 27, 2024
@mmartinv
Copy link
Contributor

mmartinv commented Feb 27, 2024 •
edited
Loading

I found cargo-vendor-filterer command by chance and it looks like it does exactly what we want:

cargo install cargo-vendor-filterer
rm -rf vendor
cargo vendor-filterer --platform='x86_64-unknown-linux-gnu'

@mmartinv mmartinv mentioned this issue Feb 28, 2024
Merged
@mergify mergify bot closed this as completed in #634 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmartinv mmartinv

Labels
dependencies Pull requests that update a dependency file distro Distro related things such as packaging good first issue Good for newcomers jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: vendored tarfile creation mmartinv/fido-device-onboard-rs
3 participants
@nullr0ute @7flying @mmartinv