Merge pull request #651 from 7flying/fix-clippy-warnings

fix: static-mut-refs warning

libfdo-data/src/lib.rs

@@ -1,4 +1,5 @@
 use libc::c_char;
+use std::ptr::addr_of;
 use std::{ffi::CString, ptr::null_mut};
 
 #[cfg(test)]
@@ -41,8 +42,15 @@ pub unsafe extern "C" fn fdo_free_string(s: *mut c_char) {
 /// be freed with `fdo_free_string`
 #[no_mangle]
 pub extern "C" fn fdo_get_last_error() -> *mut c_char {
-    match unsafe { &LAST_ERROR } {
-        None => null_mut(),
-        Some(e) => CString::new(e.as_bytes()).unwrap().into_raw(),
+    let result = unsafe { addr_of!(LAST_ERROR) };
+    if result.is_null() {
+        null_mut()
+    } else {
+        match unsafe { result.as_ref() } {
+            None => null_mut(),
+            Some(e) => CString::new(e.clone().unwrap().as_bytes())
+                .unwrap()
+                .into_raw(),
+        }
     }
 }

owner-onboarding-server/src/handlers.rs

@@ -664,6 +664,7 @@ pub(super) async fn done(
 }
 
 #[derive(Debug)]
+#[allow(dead_code)]
 struct RtrFailure(anyhow::Error);
 impl warp::reject::Reject for RtrFailure {}
 

serviceinfo-api-server/src/main.rs

@@ -15,6 +15,7 @@ use tokio::signal::unix::{signal, SignalKind};
 use warp::Filter;
 
 #[derive(Debug)]
+#[allow(dead_code)]
 struct ServiceInfoFailure(anyhow::Error);
 impl warp::reject::Reject for ServiceInfoFailure {}