Skip to content

Commit

Permalink
fix(data-formats): Use correct CBOR serializer for Error messages
Browse files Browse the repository at this point in the history
Use `serde_tuple` to serialize/deserialize the error messages
as a CBOR arrays instead of a CBOR maps as described in the
FIDO Device Onboard Specification.

Fixes: #620

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
  • Loading branch information
mmartinv committed Feb 27, 2024
1 parent 0d781b3 commit 8bb1e0c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions data-formats/src/messages/v10/error.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use serde::{Deserialize, Serialize};
use serde_tuple::{Deserialize_tuple, Serialize_tuple};

use crate::{
constants::{ErrorCode, MessageType},
messages::{ClientMessage, EncryptionRequirement, Message, ServerMessage},
};

#[derive(Debug, Serialize, Deserialize)]
#[derive(Debug, Serialize_tuple, Deserialize_tuple)]
pub struct ErrorMessage {
error_code: ErrorCode,
previous_message_type: MessageType,
Expand Down
4 changes: 2 additions & 2 deletions data-formats/src/messages/v11/error.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use serde::{Deserialize, Serialize};
use serde_tuple::{Deserialize_tuple, Serialize_tuple};

use crate::{
constants::{ErrorCode, MessageType},
messages::{ClientMessage, EncryptionRequirement, Message, ServerMessage},
};

#[derive(Debug, Serialize, Deserialize)]
#[derive(Debug, Serialize_tuple, Deserialize_tuple)]
pub struct ErrorMessage {
error_code: ErrorCode,
previous_message_type: MessageType,
Expand Down

0 comments on commit 8bb1e0c

Please sign in to comment.