Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few tweaks for Python 3 #31

Closed
wants to merge 19 commits into from
Closed

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented Oct 1, 2013

Working on getting MySQLdb to work in Python 3.

Current status:

$ tox -e py33
...
Ran 69 tests in 6.115s

FAILED (errors=22)
...

@@ -0,0 +1,12 @@
[tox]
envlist = py25, py26, py27, py33
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request should not work with py25.

@vstinner
Copy link

vstinner commented Apr 7, 2014

What is the status of this issue? I would like Python 3 support for MySQL-python.

because it's generated from metadata.cfg

and because I keep getting annoying diffs because of newline differences
-- e.g.:

    $ git diff
    diff --git a/MySQLdb/release.py b/MySQLdb/release.py
    index 5c30a6c..4ce9412 100644
    --- a/MySQLdb/release.py
    +++ b/MySQLdb/release.py
    @@ -1,4 +1,4 @@
    -
    -__author__ = "Andy Dustman <farcepest@gmail.com>"
    -version_info = (1,2,4,'final',1)
    -__version__ = "1.2.4"
    +
    +__author__ = "Andy Dustman <farcepest@gmail.com>"
    +version_info = (1,2,4,'final',1)
    +__version__ = "1.2.4"
These are reasonably modern versions of Python that I think are worth
supporting for the planned 1.3.0 release.
It makes tests take longer to install deps and now causes this error on
Python < 2.7, because of IPython 2.0.0 requiring 2.7:

    ERROR: IPython requires Python Version 2.7 or above.
@msabramo
Copy link
Contributor Author

Note: #48 is extremely similar.

@methane methane mentioned this pull request Apr 18, 2014
@msabramo
Copy link
Contributor Author

Check out #62. @methane has taken what I have here and added a bunch of great stuff, including modifying the C code to not segfault on Python 3.

@msabramo
Copy link
Contributor Author

Ping

@msabramo
Copy link
Contributor Author

This project hasn't had a commit in over a year, so I'll just close this.

@msabramo msabramo closed this Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants