Fix duckdb build failure #11059
Open
Fix duckdb build failure #11059
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
zuyu
reviewed
Sep 21, 2024
| @@ -50,7 +50,7 @@ if(DEFINED ENV{INSTALL_PREFIX}) | |||
| list(APPEND CMAKE_PREFIX_PATH "$ENV{INSTALL_PREFIX}") | |||
| # Allow installed package headers to be picked up before brew/system package | |||
| # headers | |||
| include_directories(BEFORE "$ENV{INSTALL_PREFIX}/include") | |||
| include_directories("$ENV{INSTALL_PREFIX}/include") | |||
There was a problem hiding this comment.
Please also remove the comment regarding the before ordering above.
Just curious, since we already have CMAKE_PREFIX_PATH to include $INSTALL_PREFIX, do we need include_directories("$ENV{INSTALL_PREFIX}/include") at all?
There was a problem hiding this comment.
Please also remove the comment regarding the
beforeordering above.Just curious, since we already have
CMAKE_PREFIX_PATHto include$INSTALL_PREFIX, do we needinclude_directories("$ENV{INSTALL_PREFIX}/include")at all?
Good catch. I actually think include_directories("$ENV{INSTALL_PREFIX}/include") is not needed. I will try it on a new repo tomorrow.
Upgrade FBOS dependencies to 2024.09.16.00 installs all dependencies in deps-install subfolder, and set the include directory to it in front of other include directories. This caused duckdb build failed with "error: use of undeclared identifier 'FMT_SNPRINTF'". This commit removes the BEFORE keyword to fix the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve dependency install and build (#10920) installs all dependencies in
deps-install subfolder, and set the include directory to it in front of
other include directories. This caused duckdb build failed with "error:
use of undeclared identifier 'FMT_SNPRINTF'". This commit removes the
BEFORE keyword to fix the problem.
Fixes #11058