set m_read_opts.ignore_range_deletions properly #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore_range_deletions should be set to true when range del is not enabled
|
@yoshinorim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
whats the motivation of this change? |
if dont |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 16, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 16, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 20, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 28, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
alanliang
pushed a commit
to alanliang/mysql-5.6
that referenced
this pull request
Mar 4, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 GitHub Author: leipeng <peng@topling.cn> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: pgl Reviewed By: pgl Subscribers: pgl, webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D39115879 Tags: accept2ship
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Mar 4, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Mar 29, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 13, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Apr 14, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 14, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 21, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 24, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 24, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 25, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 26, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 10, 2023
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 12, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 12, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 18, 2023
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 13, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 24, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 27, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
May 31, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 5, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 10, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 12, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 12, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Jul 25, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Jul 30, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary:
If the intrinsic tmp tables goes beyond some threshold, then we commit the write batch accumulated so far and start new transaction handling the write batch.
**Changes**
* Added a variable rocksdb_max_intrinsic_tmp_table_write_count which controls the size of write batch allowed for intrinsic tmp table. Once we cross that threshold, we will commit the current transaction and then start a new transaction.
* If there are valid open iterators before we commit intrinsic tmp table transaction, then we refresh all iterators back to previous position after committing transaction. Recursive cte opens multiple iterators for same transaction and we need to refresh all iterators after we commit the current write batch for transaction.
* I also refreshed the iterators after the first write to the write batch. This is done to handle the special case where we start rocksdb iterator on new transaction(with empty write batch). Then iterator will only see the already committed data, but ignores any new data added in write batch later. So we are pro-actively refresh the iterator after first write in write batch.
* Added a status variable rocksdb_intrinsic_tmp_table_commits to count number of intrinsic tmp table commits.
* create_ondisk_from_heap method uses table->record[1] for insertion. Myrocks encode_value_slice relies on table->record[0] for value encoding. We have reposition the fields in write_row specifically for intrinsic tmp table to point to record[1]. Better way to fix this is to remove the dependency on record[1] from encode_value_slice method and add dependency on input buf from write_row.
Reviewed By: luqun
Differential Revision: D37835016
---------------------------------------------------------------------------------------
Temporarily disable some of rocksdb.tmp_table test
Summary:
RocksDB tmp table needs bug fixes, and meanwhile
disabling some of the rocksdb.tmp_table tests so that it won't
report failures.
Reviewed By: lth
Differential Revision: D41391615
---------------------------------------------------------------------------------------
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary:
ignore_range_deletions should be set to true when range del is not enabled
Pull Request resolved: facebook#1218
Reviewed By: Pushapgl
Differential Revision: D39115879
Pulled By: yoshinorim
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 21, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 28, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 30, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Sep 23, 2024
Upstream commit ID: facebook/mysql-5.6@238afbb PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494) Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook/mysql-5.6#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb86590c8f9be44dfa3f74277fb3f49a6d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_range_deletions should be set to true when range del is not enabled