Fix proxy deserialization bug from #120 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #120 introduced some shims for converting between Colmena's serialization utilities and ProxyStore's expected serialized type of bytes. One of these shims had a typo of "serialize" instead of "deserialize". I think this did not get caught by CI because there's no test for queues with ProxyStore enabled, there's just tests for manually passing proxies as function inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #120 introduced some shims for converting between Colmena's serialization utilities and ProxyStore's expected serialized type of bytes. One of these shims had a typo of "serialize" instead of "deserialize".
I think this did not get caught by CI because there's no test for queues with ProxyStore enabled, there's just tests for manually passing proxies as function inputs.
Fortunately, #120 hasn't made it into a release yet.
The failed Ci test (
test_reallocator_deadlock) seems like it might be flakey. Everything passes fine locally.