Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refs #29) added fetch citygml url #32

Merged
merged 14 commits into from
Sep 29, 2023
Merged

Conversation

niryuu
Copy link

@niryuu niryuu commented Aug 17, 2023

No description provided.

@niryuu
Copy link
Author

niryuu commented Aug 17, 2023

gain coverage.

@smellman
Copy link
Contributor

  • write API document
  • add test case with mock
  • update README.md

@smellman smellman self-requested a review August 17, 2023 05:43
Copy link
Contributor

@smellman smellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-requirements.txt generate by pip freeze > dev-requirements.txt
requirements.txt is small set for application running.

requirements.txt Outdated
@@ -1,5 +1,13 @@
certifi==2023.7.22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need?

requirements.txt Outdated
@@ -1,5 +1,13 @@
certifi==2023.7.22
charset-normalizer==3.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need?

requirements.txt Outdated
click==8.1.3
frozendict==2.3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need?

requirements.txt Outdated
click==8.1.3
frozendict==2.3.8
idna==3.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need?

requirements.txt Outdated
numpy==1.24.3
python-dateutil==2.7.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need?

requirements.txt Outdated
six==1.16.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need?

@@ -9,6 +9,7 @@ click==8.1.3
coverage==7.2.7
docutils==0.20.1
exceptiongroup==1.1.1
httpretty==1.1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing reearthcmsapi==0.0.2 for dev-requirements.txt

@niryuu
Copy link
Author

niryuu commented Sep 7, 2023

dev-requirements.txt generate by pip freeze > dev-requirements.txt requirements.txt is small set for application running.

I understood the concept. I will fix it.

Copy link
Contributor

@smellman smellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smellman smellman merged commit 96b09ef into main Sep 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants