Merge pull request #13 from alanwillms/fix-isset

Fix __isset missing `isset`
euautomation · Jan 5, 2020 · e26f543 · e26f543
2 parents bacb19a + 4a8f84f
commit e26f543
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 41 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/Response.php b/src/Response.php
@@ -98,9 +98,9 @@ public function __set($name, $value)
      */
     public function __isset($name)
     {
-        return $this->data->{$name};
+        return isset($this->data->{$name});
     }
-    
+
     /**
      * @param $name
      */

diff --git a/tests/ResponseTest.php b/tests/ResponseTest.php
@@ -117,4 +117,16 @@ public function testIssetReturnsCorrectly()
         static::assertTrue(isset($response->One->translations[0]->code));
         static::assertNotTrue(isset($response->Two->translations[0]->code));
     }
-}
+
+    public function testIssetReturnsCorrectlyWithMissingField()
+    {
+        $data = '{"data":{"One":1}}';
+
+        $jsonObj = json_decode($data);
+
+        $response = new Response($jsonObj);
+
+        static::assertTrue(isset($response->One));
+        static::assertNotTrue(isset($response->Two));
+    }
+}