Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipstation Integration #5320

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Shipstation Integration #5320

wants to merge 5 commits into from

Conversation

Linker44
Copy link
Contributor

@Linker44 Linker44 commented Sep 23, 2024

Closes #INTS-71

Description Of Changes

This is a PR for the ShipStation Integration

Shipstation has a customers endpoint but doesn't allow filtering customers by email nor phone number, to get the customer we need the customerId.
So in order to get the customer i had to map a request flow where i would first list all the orders(GET orders) filtered by an external reference being 'customerName' and then postprocess the results to match the userEmail from there extract the customerId which i then use to call GET customer.

Code Changes

  • added config and dataset yml files
  • added tests
  • added svg

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 8:30pm

Copy link

cypress bot commented Sep 23, 2024

fides    Run #10100

Run Properties:  status check passed Passed #10100  •  git commit 93fcf93cac ℹ️: Merge 27ba0c3ff80aed8651263e6991994368e3984dd7 into 41094b7274adb21532c23abbd898...
Project fides
Branch Review refs/pull/5320/merge
Run status status check passed Passed #10100
Run duration 00m 39s
Commit git commit 93fcf93cac ℹ️: Merge 27ba0c3ff80aed8651263e6991994368e3984dd7 into 41094b7274adb21532c23abbd898...
Committer Facundo Lopez Janza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant