Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2796: ignore 400 errors on Talkable's person endpoint #5317

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Sep 23, 2024

Closes PROD-2796

Description Of Changes

Ignores 400 errors thrown by Talkable when a person is not found.

{
  'action_type': 'access',
  'system_key': 'talkable',
  'connection_key': 'talkable_api', 
  'collection': 'person', 
  'privacy_request_id': 'pri_[REDACTED]', 
  'method': 'GET', 
  'url': 'https://www.talkable.com/api/v2/people/[REDACTED]/personal_data?site_slug=[REDACTED]', 
  'response': '{"ok":false,"error_message":"No person found by `person_slug`."}', 
  'status_code': 400, 'error_group': 'ClientSideError'
}

Ideally we'd only ignore the 400s when the error message matches that case, but for now, we'll ignore all 400 errors. We can implement that when #5211 is merged.

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@RobertKeyser RobertKeyser self-assigned this Sep 23, 2024
@RobertKeyser RobertKeyser requested a review from a team as a code owner September 23, 2024 17:39
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 5:41pm

Copy link

cypress bot commented Sep 23, 2024

fides    Run #10058

Run Properties:  status check passed Passed #10058  •  git commit ef8a9ae620 ℹ️: Merge 7c64b8d7f0f159b4367e565727063375731a82d9 into b4e014f2001d57284659a686651e...
Project fides
Branch Review refs/pull/5317/merge
Run status status check passed Passed #10058
Run duration 00m 40s
Commit git commit ef8a9ae620 ℹ️: Merge 7c64b8d7f0f159b4367e565727063375731a82d9 into b4e014f2001d57284659a686651e...
Committer Robert Keyser
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@RobertKeyser RobertKeyser changed the title fix: ignore 400 errors on Talkable's person endpoint PROD-2796: ignore 400 errors on Talkable's person endpoint Sep 23, 2024
@RobertKeyser RobertKeyser merged commit d5986a5 into main Sep 23, 2024
35 of 37 checks passed
@RobertKeyser RobertKeyser deleted the rkeyser/prod-2796 branch September 23, 2024 17:56
Copy link

cypress bot commented Sep 23, 2024

fides    Run #10061

Run Properties:  status check passed Passed #10061  •  git commit d5986a5c39: PROD-2796: ignore 400 errors on Talkable's person endpoint (#5317)
Project fides
Branch Review main
Run status status check passed Passed #10061
Run duration 00m 42s
Commit git commit d5986a5c39: PROD-2796: ignore 400 errors on Talkable's person endpoint (#5317)
Committer Robert Keyser
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants