Fix Preview when Adding Languages to Experience Config #5316
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5316/merge
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
gilluminate
force-pushed
the
PROD-2715-no-preview-when-adding-language
branch
from
ff062c1
to
b6b0fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2715
Description Of Changes
When we're adding languages in the Admin UI to an Experience Config, we should see them on the preview until they're saved, the preview just had the exp.title, exp.description, etc. because the new language wasn't included in the
available_localeslist.This update ensures that the
available_localeslist always includes the currently edited language locale.Code Changes
available_localeslist with that language's locale.Steps to Confirm
Note: For better context, watch the Loom on the original bug report in Jira
Pre-Merge Checklist
CHANGELOG.md