Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-2768 Add Gzip Middleware #5307

Draft
wants to merge 1 commit into
base: release-2.43.2
Choose a base branch
from
Draft

PROD-2768 Add Gzip Middleware #5307

wants to merge 1 commit into from

Conversation

erosselli
Copy link
Contributor

Description Of Changes

Adds the GZipMiddleware to 2.43.1, hoping to resolve PROD-2768. This middleware was already added to Fides in 2.44.0

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Sep 20, 2024 5:34pm

@erosselli erosselli marked this pull request as draft September 20, 2024 17:34
@erosselli erosselli added the do not merge Please don't merge yet, bad things will happen if you do label Sep 20, 2024
@pattisdr
Copy link
Contributor

Worth a try here for PROD-2768 👍

@cypress Cypress
Copy link

cypress bot commented Sep 20, 2024

fides    Run #10027

Run Properties:  status check passed Passed #10027  •  git commit f922257d92 ℹ️: Merge 5405b837d76abb7e8a4a79ab2e3ebefb1347bbc6 into 3410c4285130012b92933ee02da4...
Project fides
Branch Review refs/pull/5307/merge
Run status status check passed Passed #10027
Run duration 00m 41s
Commit git commit f922257d92 ℹ️: Merge 5405b837d76abb7e8a4a79ab2e3ebefb1347bbc6 into 3410c4285130012b92933ee02da4...
Committer erosselli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Please don't merge yet, bad things will happen if you do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erosselli @pattisdr